friedkiwi/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/scsi/vmw_pvscsi: add a comment to explain the endianness

Browse Source 
Add a comment to explain the endianness of the pvscsi device. We have
no information about the endianness should be little-endian or CPU
native endian because the current driver code is designed to work only
on x86 and is not endianness aware. We assume that the pvscsi device is
implicitly little-endian.

Signed-off-by: Miao Wang <shankerwangmiao@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Message-ID: <20260710-pvscsi-endianness-v3-2-27fe1c4d1f6e@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
This commit is contained in:
Miao Wang
2026-07-10 03:21:40 +08:00
committed by Philippe Mathieu-Daudé
parent 5a811329bd
commit ecc569639a
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
hw/scsi/vmw_pvscsi.h
View File

@@ -108,6 +108,20 @@ enum PVSCSICommands {
#define PVSCSI_COMMAND_PROCESSING_FAILED (-1)
#define PVSCSI_COMMAND_NOT_ENOUGH_DATA (-2)
/*
* About endianess for the below structs:
*
* These structs are used to describe the data that is exchanged between the
* guest and the PVSCSI device. The endianess of the fields in these structs
* is not defined by any standard. The current implemented drivers are designed
* to only work on x86 architecture, so there is no endianess awareness in the
* drivers and thus we have no idea whether the fields should be in little-
* endian or target native endian format.
*
* Considering the above, we assume that PVSCSI is implicitly little-endian and
* expect the fields in these structs to be in little-endian format.
*/
/*
* Command descriptor for PVSCSI_CMD_RESET_DEVICE --
*/