friedkiwi/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tcg: Drop extract+shl expansions in tcg_gen_deposit_z_*

Browse Source 
The extract+shl expansion is handled in tcg_gen_andi_*
by preferring supported extract.

The shl+extract expansion is simply removed for now; it was
only present for slightly smaller code generation on x86.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20260303010833.1115741-2-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Richard Henderson
2026-03-02 05:21:16 +01:00
committed by Philippe Mathieu-Daudé
parent 31ee190665
commit c1d5ef32e7
1 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tcg/tcg-op.c
View File

@@ -937,21 +937,6 @@ void tcg_gen_deposit_z_i32(TCGv_i32 ret, TCGv_i32 arg,
TCGv_i32 zero = tcg_constant_i32(0);
tcg_gen_op5ii_i32(INDEX_op_deposit, ret, zero, arg, ofs, len);
} else {
/*
* To help two-operand hosts we prefer to zero-extend first,
* which allows ARG to stay live.
*/
if (TCG_TARGET_extract_valid(TCG_TYPE_I32, 0, len)) {
tcg_gen_extract_i32(ret, arg, 0, len);
tcg_gen_shli_i32(ret, ret, ofs);
return;
}
/* Otherwise prefer zero-extension over AND for code size. */
if (TCG_TARGET_extract_valid(TCG_TYPE_I32, 0, ofs + len)) {
tcg_gen_shli_i32(ret, arg, ofs);
tcg_gen_extract_i32(ret, ret, 0, ofs + len);
return;
}
tcg_gen_andi_i32(ret, arg, (1u << len) - 1);
tcg_gen_shli_i32(ret, ret, ofs);
}
@@ -2210,21 +2195,6 @@ void tcg_gen_deposit_z_i64(TCGv_i64 ret, TCGv_i64 arg,
TCGv_i64 zero = tcg_constant_i64(0);
tcg_gen_op5ii_i64(INDEX_op_deposit, ret, zero, arg, ofs, len);
} else {
/*
* To help two-operand hosts we prefer to zero-extend first,
* which allows ARG to stay live.
*/
if (TCG_TARGET_extract_valid(TCG_TYPE_I64, 0, len)) {
tcg_gen_extract_i64(ret, arg, 0, len);
tcg_gen_shli_i64(ret, ret, ofs);
return;
}
/* Otherwise prefer zero-extension over AND for code size. */
if (TCG_TARGET_extract_valid(TCG_TYPE_I64, 0, ofs + len)) {
tcg_gen_shli_i64(ret, arg, ofs);
tcg_gen_extract_i64(ret, ret, 0, ofs + len);
return;
}
tcg_gen_andi_i64(ret, arg, (1ull << len) - 1);
tcg_gen_shli_i64(ret, ret, ofs);
}