friedkiwi/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/i386/x86: free oem_id and oem_table_id on finalization

Browse Source 
x86_machine_initfn allocates oem_id and oem_table_id via g_strndup,
but no instance_finalize existed for x86_machine_info, so these
strings were never freed when the object was destroyed.

Add x86_machine_finalize to release both fields.

Fixes: d07b22863b ("acpi: Move setters/getters of oem fields to X86MachineState")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Marc-André Lureau
2026-04-27 14:47:27 +04:00
parent dc5d5800f8
commit 46d619d018
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
hw/i386/x86.c
View File

@@ -372,6 +372,14 @@ static void x86_machine_initfn(Object *obj)
x86ms->above_4g_mem_start = 4 * GiB;
}
static void x86_machine_finalize(Object *obj)
{
X86MachineState *x86ms = X86_MACHINE(obj);
g_free(x86ms->oem_id);
g_free(x86ms->oem_table_id);
}
static void x86_machine_class_init(ObjectClass *oc, const void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
@@ -445,6 +453,7 @@ static const TypeInfo x86_machine_info = {
.abstract = true,
.instance_size = sizeof(X86MachineState),
.instance_init = x86_machine_initfn,
.instance_finalize = x86_machine_finalize,
.class_size = sizeof(X86MachineClass),
.class_init = x86_machine_class_init,
.interfaces = (const InterfaceInfo[]) {