friedkiwi/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cocci: Do not initialize variable used by QTAILQ_FOREACH macro

Browse Source 
The QTAILQ_FOREACH() macro, defined in "qemu/queue.h",
always assigns its iterator variable when entering the
loop. Remove the pointless and possibly misleading
assignment.

Mechanical patch using the following coccinelle spatch:

  @@
  type T;
  identifier e;
  iterator FOREACH_MACRO =~ ".*_FOREACH.*";
  statement S;
  @@
  -    T *e = ...;
  +    T *e;
       ... when != e
       FOREACH_MACRO(e, ...) S

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Message-Id: <20260415215539.92629-5-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé
2026-04-15 23:11:08 +02:00
parent 122a3dd50a
commit 29e182003b
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hw/ppc/spapr.c
View File

@@ -3685,7 +3685,7 @@ struct SpaprDimmState {
static SpaprDimmState *spapr_pending_dimm_unplugs_find(SpaprMachineState *s,
PCDIMMDevice *dimm)
{
SpaprDimmState *dimm_state = NULL;
SpaprDimmState *dimm_state;
QTAILQ_FOREACH(dimm_state, &s->pending_dimm_unplugs, next) {
if (dimm_state->dimm == dimm) {

4
hw/ppc/spapr_events.c
View File

@@ -460,7 +460,7 @@ static void rtas_event_log_queue(SpaprMachineState *spapr,
static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
uint32_t event_mask)
{
SpaprEventLogEntry *entry = NULL;
SpaprEventLogEntry *entry;
QTAILQ_FOREACH(entry, &spapr->pending_events, next) {
const SpaprEventSource *source =
@@ -482,7 +482,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
static bool rtas_event_log_contains(SpaprMachineState *spapr, uint32_t event_mask)
{
SpaprEventLogEntry *entry = NULL;
SpaprEventLogEntry *entry;
QTAILQ_FOREACH(entry, &spapr->pending_events, next) {
const SpaprEventSource *source =

4
net/colo-compare.c
View File

@@ -1396,7 +1396,7 @@ static void colo_compare_init(Object *obj)
void colo_compare_cleanup(void)
{
CompareState *tmp = NULL;
CompareState *tmp;
CompareState *n = NULL;
QTAILQ_FOREACH_SAFE(tmp, &net_compares, next, n) {
@@ -1407,7 +1407,7 @@ void colo_compare_cleanup(void)
static void colo_compare_finalize(Object *obj)
{
CompareState *s = COLO_COMPARE(obj);
CompareState *tmp = NULL;
CompareState *tmp;
qemu_mutex_lock(&colo_compare_mutex);
QTAILQ_FOREACH(tmp, &net_compares, next) {

2
net/net.c
View File

@@ -653,7 +653,7 @@ static ssize_t filter_receive_iov(NetClientState *nc,
NetPacketSent *sent_cb)
{
ssize_t ret = 0;
NetFilterState *nf = NULL;
NetFilterState *nf;
if (direction == NET_FILTER_DIRECTION_TX) {
QTAILQ_FOREACH(nf, &nc->filters, next) {

2
target/s390x/kvm/stsi-topology.c
View File

@@ -285,7 +285,7 @@ static void s390_topology_fill_list_sorted(S390TopologyList *topology_list)
*/
static void s390_topology_empty_list(S390TopologyList *topology_list)
{
S390TopologyEntry *entry = NULL;
S390TopologyEntry *entry;
S390TopologyEntry *tmp = NULL;
QTAILQ_FOREACH_SAFE(entry, topology_list, next, tmp) {