friedkiwi/qemu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel_iommu: Minimal handling of privileged ATS request

Browse Source 
The purpose of this commit is not to support privileged requests but
to prevent devices from doing things they wouldn't be able to do
with real hardware.

We simply block privileged requests when the SRS ecap is not set
and abort when the ecap is present.

For now, its not worth implementing support for privileged requests
because the kernel does not support it.
(https://lore.kernel.org/linux-iommu/20230411064815.31456-11-baolu.lu@linux.intel.com/)
However, we may consider working on it depending on how the development
goes in the kernel.

Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20251029105137.1097933-7-clement.mathieu--drif@eviden.com>
This commit is contained in:
CLEMENT MATHIEU--DRIF
2025-10-29 10:51:45 +00:00
committed by Michael S. Tsirkin
parent e08a72d217
commit 0acb2b193b
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
hw/i386/intel_iommu.c
View File

@@ -5190,13 +5190,27 @@ static IOMMUTLBEntry vtd_iommu_ats_do_translate(IOMMUMemoryRegion *iommu,
hwaddr addr,
IOMMUAccessFlags flags)
{
IOMMUTLBEntry entry;
IOMMUTLBEntry entry = { .target_as = &address_space_memory };
VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
IntelIOMMUState *s = vtd_as->iommu_state;
/* Guard that makes sure we avoid weird behaviors */
if ((flags & IOMMU_PRIV) && (s->ecap & VTD_ECAP_SRS)) {
error_report_once("Privileged ATS not supported");
abort();
}
if (vtd_is_interrupt_addr(addr)) {
vtd_report_ir_illegal_access(vtd_as, addr, flags & IOMMU_WO);
vtd_prepare_error_entry(&entry);
entry.target_as = &address_space_memory;
vtd_report_ir_illegal_access(vtd_as, addr, flags & IOMMU_WO);
} else if ((flags & IOMMU_PRIV) && !(s->ecap & VTD_ECAP_SRS)) {
/*
* For translation-request-with-PASID with PR=1, remapping hardware
* not supporting supervisor requests (SRS=0 in the Extended
* Capability Register) forces R=W=E=0 in addition to setting PRIV=1.
*/
vtd_prepare_error_entry(&entry);
entry.perm = IOMMU_PRIV;
} else {
entry = vtd_iommu_translate(iommu, addr, flags, VTD_IDX_ATS);
}