From e4b833c21e1032cdcf5edfb7de3dee71ca07fb53 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 22 Apr 2026 09:11:44 +0200 Subject: [PATCH] tests/functional/qemu_test: Silence warnings from pylint in tesseract.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Pylint complains: tesseract.py:1:0: C0114: Missing module docstring (missing-module-docstring) tesseract.py:12:0: C0116: Missing function or method docstring (missing-function-docstring) tesseract.py:15:11: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check) tesseract.py:12:30: W0613: Unused argument 'tesseract_args' (unused-argument) Thus add the missing bits and remove the unused tesseract_args argument. While we're at it, also add a SPDX identifier instead of the weird three dots at the beginning of the file, and drop the license boilerplate text. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Message-ID: <20260422071145.244820-1-thuth@redhat.com> --- tests/functional/qemu_test/tesseract.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/functional/qemu_test/tesseract.py b/tests/functional/qemu_test/tesseract.py index 862faec2d2..9d98181cb4 100644 --- a/tests/functional/qemu_test/tesseract.py +++ b/tests/functional/qemu_test/tesseract.py @@ -1,19 +1,21 @@ -# ... +# SPDX-License-Identifier: GPL-2.0-or-later # # Copyright (c) 2019 Philippe Mathieu-Daudé -# -# This work is licensed under the terms of the GNU GPL, version 2 or -# later. See the COPYING file in the top-level directory. +''' +Tesseract is an program for doing Optical Character Recognition (OCR), +which can be used in the tests to extract text from screenshots. +''' import logging from subprocess import run -def tesseract_ocr(image_path, tesseract_args=''): +def tesseract_ocr(image_path): + ''' Run the tesseract OCR to extract text from a screenshot ''' console_logger = logging.getLogger('console') console_logger.debug(image_path) proc = run(['tesseract', image_path, 'stdout'], - capture_output=True, encoding='utf8') + capture_output=True, encoding='utf8', check=False) if proc.returncode: return None lines = []