From 504f2bad932c4f1b067d3b759597ed38e57576a1 Mon Sep 17 00:00:00 2001 From: Rohitashv Kumar Date: Mon, 13 Jul 2026 19:45:11 +0000 Subject: [PATCH] net: only advertise passt in netdev help when CONFIG_PASST MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit show_netdevs() lists each conditionally-compiled netdev backend behind its CONFIG_* guard (CONFIG_SLIRP for "user", CONFIG_L2TPV3 for "l2tpv3", CONFIG_NET_BRIDGE for "bridge", ...). The "passt" entry was added unconditionally, so "-netdev help" advertises passt even in builds configured with --disable-passt. Trying to use it then fails with "Parameter 'type' does not accept value 'passt'", since the QAPI NetClientDriver enum member "passt" is gated by 'if': 'CONFIG_PASST'. Guard the help entry with CONFIG_PASST so the advertised backends match those actually compiled into the binary. Signed-off-by: Rohitashv Kumar Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Puranjay Mohan Message-ID: <20260713194511.1058450-1-rohit.kuma1313@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- net/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/net.c b/net/net.c index 2892f1730d..5c39f8e7b4 100644 --- a/net/net.c +++ b/net/net.c @@ -1385,7 +1385,9 @@ void show_netdevs(void) "dgram", "hubport", "tap", +#ifdef CONFIG_PASST "passt", +#endif #ifdef CONFIG_SLIRP "user", #endif